Add description field in task and trigger protos #6722
Conversation
Signed-off-by: Alex Wu <[email protected]>
|
Bito Automatic Review Skipped - Branch Excluded |
wild-endeavor
left a comment
wild-endeavor
left a comment
There was a problem hiding this comment.
let's add validation everywhere?
flyteidl2/task/environment.proto
Outdated
| ]; | ||
|
|
||
| // Optional description of environment | ||
| string description = 2; |
There was a problem hiding this comment.
let's add the validation here also, we can always remove it in the future but i think safer to add for now.
There was a problem hiding this comment.
I've added string length validation to every description field, thanks!
|
|
||
| // Link to source code used to define this entity | ||
| message SourceCode { | ||
| string link = 1; |
There was a problem hiding this comment.
we can also consider sending a remote, a file path, and a line number, and letting the backend construct the actual link. but this is okay for now.
flyteidl2/task/task_definition.proto
Outdated
| string link = 1; | ||
| } | ||
|
|
||
| message DescriptionEntity { |
There was a problem hiding this comment.
I really don't like this name but I can't think of anything better. cc @pingsutw any ideas?
There was a problem hiding this comment.
@wild-endeavor Is the proto name "DocumentationEntity" sounds good to you?
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
|
Bito Automatic Review Skipped - Branch Excluded |
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
|
Bito Automatic Review Skipped - Branch Excluded |
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
|
Bito Automatic Review Skipped - Branch Excluded |
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
|
Bito Automatic Review Skipped - Branch Excluded |
Why are the changes needed?
Add description field to Task and Trigger protos
What changes were proposed in this pull request?
Update proto and regenerate
Check all the applicable boxes